patch for 0.1

[wision]

I did 'small' patch for otdm 0.1 which fix couple of bugs, add new functionality and remove some annoying things. since r1ch is too busy or his irc client is broken (probably both), i'll post this patch here so he can check it anytime.

NEW: removed dropping during warmup/countdown
NEW: changing skin is forbidden now (it's TDM use teamskin!)
NEW: wave flood protection
NEW: better playerlist (with id/team)
NEW: lock team feature
NEW: teamready, teamnotready, notready
NEW: player picking
NEW: setting team skin
NEW: setting team name
FIX/NEW: vote timelimit/map/kick/weapons/powerups/mode/yes/no (finally works!)
FIX: after match, teams stay unchanged (teams change only between maps.. need to fix it :X)
FIX: score for 2nd team is updating now
FIX: match ends when some of teams has no players
FIX: set captain when captain leaves
FIX: unlock the team without players
FIX: players don't have BFG in warmup now
FIX: forbid to rejoin same team or join locked team
FIX: set skin for player who just joined a team
FIX: small fix in kickplayer message
FIX: match is not restarted when observer connects/disconnects
FIX: message flood protection
FIX: say_team (now it works.. observers can talk only to eachother during the match)

new server cvars:
flood_waves
flood_waves_waitdelay
flood_waves_perminute
tdmflags
itdmflags
itemflags
powerupflags

new client commands:
notready, unready (set player status to notready)
removeplayer, remove (remove player from team <only admin/captain>)
lockteam, lock (locks the team <only admin/captain>)
unlockteam, unlock (ulocks the team <only admin/captain>)
pickplayer, pick (immediately picks a player)
teamskin (sets skin for whole team)
teamname (sets team name <max 15 characters>)
teamready, readyteam (set ready whole team <only admin/captain>)
teamnotready, notreadyteam (set not ready whole team <only admin/captain>)
vote timelimit/map/kick/weapons/powerups/mode/yes/no (voting options)

hope it will be usefull..
http://wision.own.cz/patch-otdm-0.1.tar.gz

[zbone]

Wision, are we going right way?
If it's started from the scratch maybe better make it flexible?
Some things you made can/should be configurable (observers talk, BFG remove - I suppose warmup should be configurable weapons/armor/health).
TDM authors shared sources so maybe we can reuse TDM code if they agree with it?

[wision]

true.. it's not a problem to make something configurable (like observers' talk), but some things are not important imo (like weapons/armor/health in warmup) but it's also possible to make them configurable of course.. my goal was to make otdm at least a bit 'playable' with team* variables/commands and couple of fixes..
btw where did you see that TDM source?

[zbone]

I contacted with authors some time ago and they shared sources and approved revision and development of new features we requested.

[wision]

weird.. i tried to contact them some time ago on irc/icq and i wasn't successful :/ .. maybe they can update TDM page?

[zbone]

Wis, I investigated for 2 months to get them via gadu-gadu
I m not sure they have time for it now - it's very difficult to contact them indeed. But I understood that they are glad that someone still interested in keeping TDM alive. There are lots of new features in next beta. I proposed to R1CH get TDm as base but he wants to make it from the scratch. Poorly I see that now it is going like prevoius mods Maybe I am wrong but I don't see any general view on OpenTDM as a result of development.

[wision]

well.. i don't think that otdm is on wrong way.. but it needs 10x r1ch and not some random coder like me ..
in current version 0.1 there's almost nothing.. nothing but very good movement (movement in otdm really feels great.. couple of players already agreed on that) and that's something what no other mod has (dunno why).. so give it some time. results will come soon imho

[R1CH]

A few comments... most of that stuff looks good - I'll try and merge it in soon (unfortunately some of it is duplicated of what I have worked on already that hasn't made it into SVN). T there a few conventions I want to stick to:

TABS! I don't know whose fault it is, but some of those patches had spaces for indenting instead of tabs. Tabs only please!

Cvar naming: All cvars should begin with g_ to indicate game.

[[SkulleR]]

A quick fix against latest SVN: if some client reconnects with the same name and skin into the same client slot, corresponding CS_PLAYERSKINS configstring does not get set, as ClientUserinfoChanged assumes it didn't change.

Code:

--- p_client.c (revision 13)
+++ p_client.c (working copy)
@@ -1369,6 +1369,7 @@
  ent->inuse = false;
  ent->classname = "disconnected";
  ent->client->pers.connected = false;
+ ent->client->pers.userinfo[0] = 0;
 
  playernum = ent-g_edicts-1;
  gi.configstring (CS_PLAYERSKINS+playernum, "");

[R1CH]

Good catch .